-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ChoiceGroup): migrate to Tailwind #4143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Size Change: -437 B (0%) Total Size: 460 kB
ℹ️ View Unchanged
|
mvidalgarcia
force-pushed
the
tw/choice-group
branch
from
November 9, 2023 16:40
d38e571
to
c0f71a7
Compare
oreqizer
suggested changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, just a couple details
packages/orbit-components/src/ChoiceGroup/components/FilterWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/ChoiceGroup/components/FilterWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/ChoiceGroup/components/Feedback.tsx
Outdated
Show resolved
Hide resolved
oreqizer
force-pushed
the
tw/choice-group
branch
from
November 13, 2023 08:31
c0f71a7
to
48a3bf3
Compare
mvidalgarcia
force-pushed
the
tw/choice-group
branch
from
November 13, 2023 09:23
48a3bf3
to
aaa0377
Compare
Closes FEPLT-1707
mvidalgarcia
force-pushed
the
tw/choice-group
branch
from
November 13, 2023 09:26
aaa0377
to
65c6763
Compare
oreqizer
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FEPLT-1707
This Pull Request meets the following criteria:
For tailwind migrations:
tailwind-migration-status.yaml
file has been updated with the migrated component(s).For new components:
.flow
andd.ts
files and are exported inindex.js.flow
andindex.d.ts
Storybook: https://orbit-mainframev-tw-choice-group.surge.sh